Skip to content

Add a decision for opt-in breaking changes#491

Merged
mkmeral merged 3 commits intostrands-agents:mainfrom
zastrowm:opt_in_breaking_changes
Feb 6, 2026
Merged

Add a decision for opt-in breaking changes#491
mkmeral merged 3 commits intostrands-agents:mainfrom
zastrowm:opt_in_breaking_changes

Conversation

@zastrowm
Copy link
Member

@zastrowm zastrowm commented Jan 28, 2026

Add a record of the decision that "opt-in breaking changes" being acceptable from an SDK evolution strategy.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@strands-agent
Copy link
Contributor

strands-agent commented Jan 28, 2026

Documentation Deployment Complete

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-491/

mkmeral
mkmeral reviewed Jan 28, 2026
View reviewed changes
mkmeral
mkmeral previously approved these changes Jan 28, 2026
View reviewed changes
yonib05
yonib05 previously approved these changes Jan 28, 2026
View reviewed changes
pgrayy
pgrayy reviewed Jan 28, 2026
View reviewed changes
@zastrowm zastrowm dismissed stale reviews from yonib05 and mkmeral via f52b1c1 January 28, 2026 17:24
@strands-agent
Copy link
Contributor

strands-agent commented Jan 28, 2026

Documentation Deployment Complete

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-491/

Unshure
Unshure previously approved these changes Jan 28, 2026
View reviewed changes
pgrayy
pgrayy previously approved these changes Feb 2, 2026
View reviewed changes
@mehtarac
Copy link
Member

mehtarac commented Feb 3, 2026

/strands review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Assessment: Approve ✅

This decision record is well-written and follows the established structure in DECISIONS.md.

Key Observations:

  • Structure is consistent with prior decisions (Date, Decision, Rationale sections)
  • The "pay for play" principle is clearly explained with a concrete TypedDict example
  • Good balance of explaining when the policy applies vs. when it doesn't apply
  • External reference to Raymond Chen's post provides additional context

The updated example (addressing pgrayy's feedback) now clearly distinguishes between the producing side vs. reading side of the breaking change, making the concept more understandable.

Nice addition to the decision record! 🎉

mehtarac
mehtarac previously approved these changes Feb 3, 2026
View reviewed changes
@mkmeral mkmeral dismissed stale reviews from mehtarac, pgrayy, and Unshure via d44cccf February 3, 2026 23:13
@mkmeral mkmeral enabled auto-merge (squash) February 3, 2026 23:14
@strands-agent
Copy link
Contributor

strands-agent commented Feb 3, 2026

Documentation Deployment Complete

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-491/

1 similar comment
@strands-agent
Copy link
Contributor

strands-agent commented Feb 3, 2026

Documentation Deployment Complete

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-491/

@mkmeral mkmeral merged commit 36e716d into strands-agents:main Feb 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mehtarac mehtarac mehtarac approved these changes

@yonib05 yonib05 yonib05 left review comments

@mkmeral mkmeral mkmeral left review comments

@Unshure Unshure Unshure left review comments

@pgrayy pgrayy pgrayy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zastrowm @strands-agent @mehtarac @yonib05 @mkmeral @Unshure @pgrayy